Create a deprecation/repair for sensor.sun_solar_rising#146462
Merged
MartinHjelmare merged 3 commits intoJun 11, 2025
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
requested changes
Jun 10, 2025
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good!
Please add a test that tests issue creation and deletion.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Member
Author
|
Added test |
NoRi2909
reviewed
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In #140956 I added a binary_sensor to replace sensor.sun_solar_rising.
Now the integration has a
sensorandbinary_sensorwhich represent the same thing.This PR raises a repair if user has
sensor.sun_solar_risingenabled in their instance, and requests them to disable it for eventual removal after the deprecation period.This sensor is diabled by default and I expect very few users will have ever enabled it.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: