Skip to content

Create a deprecation/repair for sensor.sun_solar_rising#146462

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
karwosts:sun_rising_deprecation
Jun 11, 2025
Merged

Create a deprecation/repair for sensor.sun_solar_rising#146462
MartinHjelmare merged 3 commits into
home-assistant:devfrom
karwosts:sun_rising_deprecation

Conversation

@karwosts
Copy link
Copy Markdown
Member

@karwosts karwosts commented Jun 10, 2025

Proposed change

In #140956 I added a binary_sensor to replace sensor.sun_solar_rising.

Now the integration has a sensor and binary_sensor which represent the same thing.

This PR raises a repair if user has sensor.sun_solar_rising enabled in their instance, and requests them to disable it for eventual removal after the deprecation period.

This sensor is diabled by default and I expect very few users will have ever enabled it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@karwosts karwosts requested a review from a team as a code owner June 10, 2025 15:29
@home-assistant home-assistant Bot added cla-signed core deprecation Indicates a breaking change to happen in the future integration: sun Quality Scale: internal labels Jun 10, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sun) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sun can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sun Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please add a test that tests issue creation and deletion.

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft June 10, 2025 16:02
@MartinHjelmare MartinHjelmare self-assigned this Jun 10, 2025
@karwosts karwosts marked this pull request as ready for review June 10, 2025 16:48
@home-assistant home-assistant Bot requested a review from MartinHjelmare June 10, 2025 16:48
@karwosts
Copy link
Copy Markdown
Member Author

Added test

Comment thread homeassistant/components/sun/strings.json Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 5b4c309 into home-assistant:dev Jun 11, 2025
48 checks passed
@karwosts karwosts deleted the sun_rising_deprecation branch June 11, 2025 12:03
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants